Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify IsForeignConcreteAsset Implementation #2276

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Simplify IsForeignConcreteAsset Implementation #2276

wants to merge 3 commits into from
+10 −10

Conversation

NachoPal
Copy link
Contributor

Closes: #100

@NachoPal NachoPal added the T14-system_parachains This PR/Issue is related to system parachains. label Nov 10, 2023
@paritytech-review-bot paritytech-review-bot bot requested review from a team November 10, 2023 17:07
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4791511

bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Port safe commits from master to polkadot-staging (#2761)
4004742 
* introduce bp_messages::ChainWithMessages (#2171)

* Move Chain::ID from relay-level Chain to primitives-level Chain (#2181)

* move Chain::ID from relay-level Chain to primitives-level Chain

* removed chain IDs from bp-runtime

* add missing file header

* Some code grooming (#2276)

* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request May 16, 2024
@svyatonik @bkontur
Some code grooming (#2276)
8f71ed9 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request May 17, 2024
@svyatonik @bkontur
Some code grooming (#2276)
544317a 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request May 17, 2024
@svyatonik @bkontur
Some code grooming (#2276)
304c8f4 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request May 17, 2024
@svyatonik @bkontur
Some code grooming (#2276)
870e255 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request May 20, 2024
@svyatonik @bkontur
Some code grooming (#2276)
a3ab86e 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request May 21, 2024
@svyatonik @bkontur
Some code grooming (#2276)
96dd676 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request May 22, 2024
@svyatonik @bkontur
Some code grooming (#2276)
35df5a3 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request May 23, 2024
@svyatonik @bkontur
Some code grooming (#2276)
293f7ce 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request May 30, 2024
@svyatonik @bkontur
Some code grooming (#2276)
1721ed6 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request Jun 4, 2024
@svyatonik @bkontur
Some code grooming (#2276)
1fd83e3 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request Jun 5, 2024
@svyatonik @bkontur
Some code grooming (#2276)
d7d4e0a 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request Jun 7, 2024
@svyatonik @bkontur
Some code grooming (#2276)
0d2ff38 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur pushed a commit that referenced this pull request Jun 7, 2024
@svyatonik @bkontur
Some code grooming (#2276)
bbf64ef 
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds

* removed strange allow + added comment related to other allow

* removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepetrowski joepetrowski Awaiting requested review from joepetrowski

@KiChjang KiChjang Awaiting requested review from KiChjang

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
T14-system_parachains This PR/Issue is related to system parachains.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify IsForeignConcreteAsset Implementation
2 participants
@NachoPal @paritytech-cicd-pr